/libcloud

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LIBCLOUD-887 #978

Merged
merged 2 commits into from Jan 18, 2017

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@tonybaloney @asfgit
@tonybaloney
Contributor

tonybaloney commented Jan 18, 2017

If a user sets LIBCLOUD_DEBUG, they will receive an error and no requests will be made. This is happening on trunk and v2.0.0rc1-tentative

In ./libcloud/utils/loggingconnection.py
LoggingConnection.request does not accept the stream keyword which causes an error:
TypeError: request() got an unexpected keyword argument 'stream'

Reported by @supertom

tonybaloney added some commits Jan 18, 2017

@tonybaloney
create a test to prove LIBCLOUD-887 is a bug
Verified
This commit was signed with a verified signature.
@tonybaloney tonybaloney Anthony Shaw
GPG key ID: AB4A19AE1CE85744 Learn about signing commits
ed6d012
@tonybaloney
fix and also support for StringIO as enable_debug file handle argument
Verified
This commit was signed with a verified signature.
@tonybaloney tonybaloney Anthony Shaw
GPG key ID: AB4A19AE1CE85744 Learn about signing commits
57c5929
@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney Jan 18, 2017

Contributor

Passed. Merging.
Contributor

tonybaloney commented Jan 18, 2017

Passed. Merging.

@asfgit asfgit merged commit 57c5929 into apache:trunk Jan 18, 2017
1 check was pending

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

asfgit pushed a commit that referenced this pull request Jan 18, 2017

@tonybaloney
changes for #978
Verified
This commit was signed with a verified signature.
@tonybaloney tonybaloney Anthony Shaw
GPG key ID: AB4A19AE1CE85744 Learn about signing commits
419c694
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment