Skip to content

Fix LIBCLOUD-887 #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 18, 2017
Merged

Fix LIBCLOUD-887 #978

merged 2 commits into from
Jan 18, 2017

Conversation

tonybaloney
Copy link
Contributor

If a user sets LIBCLOUD_DEBUG, they will receive an error and no requests will be made. This is happening on trunk and v2.0.0rc1-tentative

In ./libcloud/utils/loggingconnection.py
LoggingConnection.request does not accept the stream keyword which causes an error:
TypeError: request() got an unexpected keyword argument 'stream'

Reported by @supertom

@tonybaloney
Copy link
Contributor Author

Passed. Merging.

@asfgit asfgit merged commit 57c5929 into apache:trunk Jan 18, 2017
asfgit pushed a commit that referenced this pull request Jan 18, 2017
@tonybaloney
changes for #978
419c694
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonybaloney @asfgit