From b61a58c2072adffdb928091df999a7cf7bf9259b Mon Sep 17 00:00:00 2001 From: challarao Date: Sat, 27 Aug 2016 04:18:16 +0530 Subject: [PATCH] Documentation bug for purgeAscending method. For "@param highIndex Log file associated with high index will be deleted if needed. " That is incorrect it seems, that applies to purgeDescending. That message should be under "@param lowIndex with the message Log file associated with low index will be deleted if needed. " Because purgeAscending deletes the one with the low index if required, if I'm not wrong. --- .../log4j/core/appender/rolling/DefaultRolloverStrategy.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/DefaultRolloverStrategy.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/DefaultRolloverStrategy.java index 833db412275..39a6215bf4e 100644 --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/DefaultRolloverStrategy.java +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/DefaultRolloverStrategy.java @@ -310,8 +310,8 @@ private int purge(final int lowIndex, final int highIndex, final RollingFileMana * Purges and renames old log files in preparation for rollover. The oldest file will have the smallest index, the * newest the highest. * - * @param lowIndex low index - * @param highIndex high index. Log file associated with high index will be deleted if needed. + * @param lowIndex low index. Log file associated with low index will be deleted if needed. + * @param highIndex high index. * @param manager The RollingFileManager * @return true if purge was successful and rollover should be attempted. */