LOG4J2-3211 - Remove Messge Lookups #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carterkozak
approved these changes
Dec 13, 2021
| @@ -38,7 +38,7 @@ public void testDateLookupInMessage(final LoggerContext context, @Named("List") | |||
| final String template = "${date:YYYY-MM-dd}"; | |||
| context.getLogger(PatternLayoutLookupDateTest.class.getName()).info(template); | |||
| final String string = listAppender.getMessages().get(0); | |||
| assertFalse(string.contains(template), string); | |||
| assertTrue(string.contains(template), string); | |||
There was a problem hiding this comment.
This class and log4j-list-lookups.xml could be deleted.
| @@ -121,7 +121,7 @@ public void testLookup() { | |||
| .setMessage(msg).build(); | |||
| final StringBuilder sb = new StringBuilder(); | |||
| converter.format(event, sb); | |||
| assertEquals("bar", sb.toString(), "Unexpected result"); | |||
| assertEquals("${foo}", sb.toString(), "Unexpected result"); | |||
There was a problem hiding this comment.
Given the feature is gone, we can probably remove this test as it’s covered elsewhere
There was a problem hiding this comment.
I didn't want to remove any test for this release. Just change them to prove the change was made.
jvz
approved these changes
Dec 13, 2021
remkop
approved these changes
Dec 13, 2021
| @@ -1497,18 +1497,6 @@ WARN [main]: Message 2</pre> | |||
| The call site can look like this: | |||
| </p> | |||
| <pre class="prettyprint linenums">logger.info("@|KeyStyle {}|@ = @|ValueStyle {}|@", entry.getKey(), entry.getValue());</pre> | |||
| <p> | |||
| Use <code>{lookups}</code> to log messages like <code>logger.info("Try ${esc.d}{date:YYYY-MM-dd}")</code> | |||
There was a problem hiding this comment.
Would it make sense to put a note here, something like this:
From Log4j 2.16.0, support for lookups in log messages has been removed for security reasons. Both the
{lookups}and the{nolookups}options on the%m,%msgand%messagepattern are now silently ignored.
mirabilos
referenced
this pull request
Dec 13, 2021
git-svn-id: https://svn.apache.org/repos/asf/logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers@1185987 13f79535-47bb-0310-9956-ffa450edef68
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.