LOG4J2-3358: Fix substitutions when programmatic configuration is used #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vy
reviewed
Jan 21, 2022
log4j-core/src/test/java/org/apache/logging/log4j/core/layout/JsonLayoutTest.java
Outdated
Show resolved
Hide resolved
|
in 2.17.1 we paired down the list of allowed lookups based on javadoc, however that wasn't correct because the objects aren't always used precisely how the AbstractConfiguration expects, leading to vastly different behavior based on how the configuration (thus StrSubstitutor) is created. |
carterkozak
force-pushed
the
LOG4J2-3358
branch
from
e7af4e0
to
646fa0f
Compare
The problem is that some configuration creation paths fail to use the Interpolator constructor which loads all plugins. This produces inconsistent behavior based on the configuration construction path. By merging code-paths, we can provide consistent behavior.
carterkozak
force-pushed
the
LOG4J2-3358
branch
from
646fa0f
to
7c219b8
Compare
carterkozak
changed the title
carterkozak
added a commit
that referenced
this pull request
Jan 22, 2022
#726) The problem is that some configuration creation paths fail to use the Interpolator constructor which loads all plugins. This produces inconsistent behavior based on the configuration construction path. By merging code-paths, we can provide consistent behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is that some configuration creation paths fail to
use the Interpolator constructor which loads all plugins. This
produces inconsistent behavior based on the configuration construction
path.
By merging code-paths, we can provide consistent behavior.