SOLR-4735 Improve Solr metrics reporting #120

Open
wants to merge 10 commits into
from

Conversation

Projects
None yet
2 participants
@sigram
Contributor

sigram commented Nov 29, 2016

This PR is based on the initial patch by Kelvin Wong, with portions from Jeff Wartes (see Jira issue for more details).

Changes include:

  • centralized metric registry management in SolrMetricManager
  • hierarchical names for metrics, both inside registries and when reported by JMX.
  • more reusable API outside of SolrCore context.
+ * @param registry registry name
+ */
+ public static void clearRegistryFor(String registry) {
+ SharedMetricRegistries.getOrCreate(overridableRegistryName(registry)).removeMatching(MetricFilter.ALL);

This comment has been minimized.

@randomstatistic

randomstatistic Nov 30, 2016

This, and several other places below could delegate to registryFor(registry)

@randomstatistic

randomstatistic Nov 30, 2016

This, and several other places below could delegate to registryFor(registry)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment