LUCENE-8608: Extract utility class to iterate over terms docs #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikemccand
approved these changes
Dec 13, 2018
lucene/core/src/java/org/apache/lucene/index/FrozenBufferedUpdates.java
Outdated
Show resolved
Hide resolved
lucene/core/src/java/org/apache/lucene/index/FrozenBufferedUpdates.java
Outdated
Show resolved
Hide resolved
lucene/core/src/java/org/apache/lucene/index/FrozenBufferedUpdates.java
Outdated
Show resolved
Hide resolved
lucene/core/src/test/org/apache/lucene/index/TestFrozenBufferedUpdates.java
Show resolved
Hide resolved
|
@mikemccand I pushed changes. I think it's ready |
Today we re-implement the same algorithm in various places when we want to consume all docs for a set/list of terms. This caused serious slowdowns for instance in the case of applying updates fixed in LUCENE-8602. This change extracts the common usage and shares the interation code including logic to reuse Terms and PostingsEnum instances as much as possble and adds tests for it.
s1monw
force-pushed
the
extract_terms_seeker
branch
from
5f82c8a
to
4272c63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we re-implement the same algorithm in various places
when we want to consume all docs for a set/list of terms. This
caused serious slowdowns for instance in the case of applying
updates fixed in LUCENE-8602. This change extracts the common
usage and shares the interation code including logic to reuse
Terms and PostingsEnum instances as much as possble and adds
tests for it.