Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SOLR-9341] GC logs go to SOLR_LOGS_DIR on Windows #53

Closed
wants to merge 1 commit into from

Conversation

@afscrome
Copy link

afscrome commented Jul 26, 2016

Don't override the SOLR_LOGS_DIR environment variable when it has already been set. This brings the windows behaviour in line with the bash script.

Don't override the SOLR_LOGS_DIR environment variable when it has already been set.  This brings the windows behaviour in line with the bash script.
@tflobbe

This comment has been minimized.

Copy link
Member

tflobbe commented Jul 26, 2016

This PR doesn't seem to be linked to any Jira. Is there one? If you include the Jira issue id in the title of the PR it will automatically show in Jira (e.g. https://issues.apache.org/jira/browse/SOLR-9279 ). You can create a new Jira issue if there isn't one for this fix

@afscrome afscrome changed the title GC logs go to SOLR_LOGS_DIR on Windows [SOLR-9341] GC logs go to SOLR_LOGS_DIR on Windows Jul 26, 2016
@afscrome

This comment has been minimized.

Copy link
Author

afscrome commented Jul 26, 2016

Sorry, I didn't realise a jira issue was required - it's not completely clear from https://wiki.apache.org/solr/HowToContribute#Working_with_GitHub .

I've created a new issue and linked it in the PR title.

@afscrome afscrome changed the title [SOLR-9341] GC logs go to SOLR_LOGS_DIR on Windows [SOLR-9342] GC logs go to SOLR_LOGS_DIR on Windows Jul 27, 2016
@afscrome afscrome changed the title [SOLR-9342] GC logs go to SOLR_LOGS_DIR on Windows [SOLR-9341] GC logs go to SOLR_LOGS_DIR on Windows Jul 27, 2016
mnilsson23 added a commit to mnilsson23/lucene-solr that referenced this pull request Aug 26, 2016
* factor out normalizers

* code review update

* code review update
@afscrome

This comment has been minimized.

Copy link
Author

afscrome commented Oct 18, 2016

Fixed in 33db4de

@afscrome afscrome closed this Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.