Revert required SegmentInfos min version in header check in readCommit to continue binary compatibility with 8.x indexes #15454
+8
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#14607 advanced the SegmentInfos version to VERSION_86 (10) in header check during readCommit() to allow tests to find backward codecs until 9.x while throwing a graceful IndexFormatTooOldException for indexes < v8.6.0 (since by default anything < 10x is "too old").
Earlier with VERSION_74 (9), readCodec() would throw an IllegalArgumentException since readCommit now checks for segment level compatibility instead of looking at when the index was first created, and would find the 7.x codecs missing for some of the old indexes. This was causing some of the tests to fail.
However #15431 made me realize that we can afford to allow binary readability on 8.x indexes like was the case previously and also keep the tests happy., This change would also help keep the core logic and constraints consistent across 10x and main.