Streamline segment info logged by infostream, esp. when merging#15885
Merged
Conversation
kkmr
approved these changes
Mar 28, 2026
mikemccand
approved these changes
Mar 31, 2026
mikemccand
left a comment
mikemccand
left a comment
Member
There was a problem hiding this comment.
Thank you @msokolov! This is likely a massive reduction in InfoStream size in practice... I left some small comments.
mikemccand
reviewed
Mar 31, 2026
mikemccand
reviewed
Mar 31, 2026
|
|
||
| if (infoStream.isEnabled("IW")) { | ||
| infoStream.message("IW", "publishFlushedSegment " + newSegment); | ||
| infoStream.message("IW", "publishFlushedSegment " + newSegment.toStringVerbose()); |
Member
There was a problem hiding this comment.
Is there also a corresponding toStringVerbose() for the merge case? addIndexes?
Contributor
Author
There was a problem hiding this comment.
do we currently emit a log message when a new segment is created by merging or addIndexes?
added 6 commits
March 31, 2026 11:43
msokolov
added a commit
that referenced
this pull request
Apr 1, 2026
mouhc1ne
added a commit
to mouhc1ne/elasticsearch
that referenced
this pull request
Apr 10, 2026
…(see apache/lucene#15885) to a less verbose message that no longer includes "timestamp". This causes this test to fail on `lucene_snapshot` branch. The `main` branch doesn't need this yet because it's still on Lucene `10.4` where the aforementioned `toString()` still emits the usual and verbose segment diagnostic that includes the timestamp.
mouhc1ne
added a commit
to elastic/elasticsearch
that referenced
this pull request
Apr 10, 2026
…(see apache/lucene#15885) to a less verbose message that no longer includes "timestamp". This causes this test to fail on `lucene_snapshot` branch. The `main` branch doesn't need this yet because it's still on Lucene `10.4` where the aforementioned `toString()` still emits the usual and verbose segment diagnostic that includes the timestamp. (#146024)
mouhc1ne
added a commit
to mouhc1ne/elasticsearch
that referenced
this pull request
Apr 14, 2026
…(see apache/lucene#15885) to a less verbose message that no longer includes "timestamp". This causes this test to fail on `lucene_snapshot` branch. The `main` branch doesn't need this yet because it's still on Lucene `10.4` where the aforementioned `toString()` still emits the usual and verbose segment diagnostic that includes the timestamp.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We've been logging infostreams in our production system and find they are overly verbose and repetitive in some ways. This takes the edge off by logging segment "diagnostic" info once per segment rather than every time the segment is mentioned, eg when listed as part of a merge