Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust CHANGES.txt to move LUCENE-9902 entry from release 8.9 to 9.0 #190

Closed

Conversation

gautamworah96
Copy link
Contributor

This change was added for release 9.0 but its changes entry was under release 8.9. This commit readjusts the file accordingly.

cc: @mayya-sharipova

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Lucene maintainers access to contribute to my PR branch. (optional but recommended)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.

@mikemccand
Copy link
Member

Hmm, is there some reason for not back-porting the change to 8.10? In general if a change can be safely backported (does not break APIs), we should bias/err towards doing so. It's not good to have 9.0-only changes for not a good reason :)

@gautamworah96
Copy link
Contributor Author

@mikemccand independently merged a commit that made the changes proposed in this PR. Thanks @mikemccand !
Closing this PR

@gautamworah96 gautamworah96 deleted the LUCENE-9902-changesfix branch June 24, 2021 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants