LUCENE-10313: minor clean-ups and follow-ups#546
Merged
Conversation
mocobeta
commented
Dec 16, 2021
mocobeta
commented
Contributor
- Fix the inequality sign for filtering log records.
- Move the log formatter class to util package.
- Allow to copy the displayed log string to the system clipboard.
- other small changes.
Contributor
|
I'd merge it in now, it looks fine and I need it for the module patch because it currently conflicts. |
dweiss
approved these changes
Dec 16, 2021
Contributor
|
I'll risk it and merge it in - hope you won't mind, @mocobeta |
Contributor
Author
|
I was late. Thank you. |
mocobeta
added a commit
that referenced
this pull request
Dec 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.