Migrated Spatial and compiled #13

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
2 participants

No description provided.

cyberram added some commits Apr 13, 2014

@cyberram cyberram Converted and fixed compile errors in
Spatial/Prefix
Spatial/Util

Also fixed some compile errors in other sections of Spatial.
e65f61b
@cyberram cyberram Merge branch 'branch_4x' of https://github.com/apache/lucene.net.git
…into branch_4x
ca7c6fe
@cyberram cyberram Fixed compile errors in Contrib/Spatial and Contrib/Spatial.NTS after…
… porting.

For the moment, converted all byte[] to sbyte[], just to get the code compiled.
9e594c2
@cyberram cyberram Converted all sbyte in Contrib/Spatial to use byte.
For sbyte references in other projects,
created extension methods to convert them.
ab9ad3d

cyberram changed the title from Branch 4x to Migrated Spatial and compiled Apr 25, 2014

cyberram commented May 2, 2014

Did anyone get a chance to review my changes?

Member

synhershko commented Aug 6, 2014

Hi, which version of Lucene did you port this code from?

Member

synhershko commented Aug 21, 2014

Do we have an ICLA on file from you?

http://www.apache.org/licenses/icla.txt

No. Just now submitted it.

Just received a confirmation that my ICLA has been filled.

Member

synhershko commented Aug 23, 2014

Thanks, I'll be reviewing this shortly

cyberram closed this Sep 20, 2014

cyberram deleted the unknown repository branch Sep 20, 2014

Member

synhershko commented Sep 21, 2014

@cyberram do you still have this branch locally? I can't merge it if you dont...

Oops. Sorry was preparing my repo for the 4.8.0 testing and I think I
accidentally removed my other branch.
I do have it in my local.

Have created another pull request for it now.
apache#20

Cheers,

Cheers,
Ramkumar.K

On Sun, Sep 21, 2014 at 8:17 PM, Itamar Syn-Hershko <
notifications@github.com> wrote:

@cyberram https://github.com/cyberram do you still have this branch
locally? I can't merge it if you dont...


Reply to this email directly or view it on GitHub
apache#13 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment