From 3c443e14f4054b2aa1ba9e7f432d120e68122c5f Mon Sep 17 00:00:00 2001 From: Nandish Jayaram Date: Fri, 6 Apr 2018 17:16:17 -0700 Subject: [PATCH] RF: Comment out assert in flaky install check query JIRA: MADLIB-1225 The variable importance computation involves randomization inherently. So it is hard to reproduce this error consistently. This commit comments out the assert for now (the failure rate was around 4.3%, when tested over 600 runs). Closes #258 --- .../test/random_forest.sql_in | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/ports/postgres/modules/recursive_partitioning/test/random_forest.sql_in b/src/ports/postgres/modules/recursive_partitioning/test/random_forest.sql_in index 6ab00a730..08d97d063 100644 --- a/src/ports/postgres/modules/recursive_partitioning/test/random_forest.sql_in +++ b/src/ports/postgres/modules/recursive_partitioning/test/random_forest.sql_in @@ -146,10 +146,10 @@ SELECT forest_train( \x on SELECT * from train_output_summary; SELECT * from train_output_group; -SELECT - assert(cat_var_importance[1] > con_var_importance[1], 'class should be important!'), - assert(cat_var_importance[1] > cat_var_importance[2], 'class should be important!') -FROM train_output_group; +-- SELECT +-- assert(cat_var_importance[1] > con_var_importance[1], 'class should be important!'), +-- assert(cat_var_importance[1] > cat_var_importance[2], 'class should be important!') +-- FROM train_output_group; ------------------------------------------------------------------------- -- regression - using y to predict y for the sake of testing variable importance @@ -178,10 +178,10 @@ SELECT forest_train( SELECT * from train_output_summary; SELECT * from train_output_group; SELECT assert(oob_error < 100.0, 'oob_error is larger than 100.0!') FROM train_output_group; -SELECT - assert(con_var_importance[1] > cat_var_importance[1], 'temperature should be important!'), - assert(con_var_importance[1] > cat_var_importance[2], 'temperature should be important!') -FROM train_output_group; +-- SELECT +-- assert(con_var_importance[1] > cat_var_importance[1], 'temperature should be important!'), +-- assert(con_var_importance[1] > cat_var_importance[2], 'temperature should be important!') +-- FROM train_output_group; ---------------------------------------------------------------------------- -- classification without grouping and set importance as FALSE