From 9c556816bcca990e9b168cf556ce0da0cacf935a Mon Sep 17 00:00:00 2001 From: Nandish Jayaram Date: Wed, 27 Jun 2018 12:40:19 -0700 Subject: [PATCH 1/2] SVM: Fix flaky dev-check failure JIRA: MADLIB-1232 SVM has a dev-check query that is flaky on a large cluster. This commit relaxes the assert condition for that query. Closes #284 --- src/ports/postgres/modules/svm/test/svm.sql_in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/ports/postgres/modules/svm/test/svm.sql_in b/src/ports/postgres/modules/svm/test/svm.sql_in index 60d280e26..18d70688f 100644 --- a/src/ports/postgres/modules/svm/test/svm.sql_in +++ b/src/ports/postgres/modules/svm/test/svm.sql_in @@ -213,7 +213,8 @@ SELECT * FROM svm_model_small_norm2; SELECT assert( - norm2(l2.coef) < norm2(noreg.coef), + norm2(l2.coef) < norm2(noreg.coef) OR + norm2(l2.coef)-norm2(noreg.coef) < 0.001, 'l2 regularization should produce coef with smaller l2 norm!') FROM svm_model AS noreg, svm_model_small_norm2 AS l2; From 9ab0ea8db95433bacbb8065a966b6ff557a2b842 Mon Sep 17 00:00:00 2001 From: Nandish Jayaram Date: Wed, 27 Jun 2018 15:57:48 -0700 Subject: [PATCH 2/2] Address PR review comments. --- src/ports/postgres/modules/svm/test/svm.sql_in | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/ports/postgres/modules/svm/test/svm.sql_in b/src/ports/postgres/modules/svm/test/svm.sql_in index 18d70688f..ad4b9acd1 100644 --- a/src/ports/postgres/modules/svm/test/svm.sql_in +++ b/src/ports/postgres/modules/svm/test/svm.sql_in @@ -214,7 +214,10 @@ SELECT * FROM svm_model_small_norm2; SELECT assert( norm2(l2.coef) < norm2(noreg.coef) OR - norm2(l2.coef)-norm2(noreg.coef) < 0.001, + ( + (norm2(l2.coef)-norm2(noreg.coef))/norm2(noreg.coef) < 0.1 AND + l2.loss < noreg.loss + ), 'l2 regularization should produce coef with smaller l2 norm!') FROM svm_model AS noreg, svm_model_small_norm2 AS l2;