Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSHARED-944] Drop support for Maven 3.0. Require 3.1.1 #20

Closed
wants to merge 3 commits into from

Conversation

slachiewicz
Copy link
Member

No description provided.

@slachiewicz slachiewicz changed the title Mshared 944 [MSHARED-944] Drop support for Maven 3.0. Require 3.1.1 Dec 26, 2020
@michael-o
Copy link
Member

Massive, will need some time for this.

@slachiewicz
Copy link
Member Author

there is nothing special - lots of removal of old maven 3.0 stuff + replacement of reflections to just us normal direct call to exposed API. No need to spent too much time here.
CI is green https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-artifact-transfer/job/MSHARED-944/

@slachiewicz
Copy link
Member Author

With these changes, it should be easier to move forward with maven-dependency-tree and other plugins - to not fight with old dependencies.

@@ -165,12 +165,12 @@
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-core</artifactId>
<version>3.0</version>
<version>3.1.1</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be moved to a property.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, will fix this next time

@rfscholte
Copy link
Contributor

Please don't do this. The intention of maven-artifact-transfer is a bridge to any Aether implementation.

@rfscholte
Copy link
Contributor

Sorry @slachiewicz if you've spend a lot of time on this, but I need to close this. Once everything is using Maven 3.1+ we can simply archive maven-artifact-transfer because it has become an unnecessary abstraction layer.

@rfscholte rfscholte closed this Dec 30, 2020
@slachiewicz
Copy link
Member Author

Do we have anywhere documented this recommendation? I think we still have on wiki to use this artefact.
Also with this changes we can easily switch to new aether impl by dep update plus remove redundant code/simplify other projects.

@rfscholte
Copy link
Contributor

I still consider adding the org.apache.maven.shared.transfer.project package a bad choice, because it introduces a dependency on Maven.
https://cwiki.apache.org/confluence/display/MAVEN/Plugin+migration+to+Maven3+dependencies does indeed talk about adding maven-artifact-transfer, but https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=155749857 should contain the removal of it.

@olamy
Copy link
Member

olamy commented Jun 23, 2022

was a good idea to get RID of old dependencies until we go away correctly from org.eclipse package.

@cstamas
Copy link
Member

cstamas commented Jun 23, 2022

Just FTR, now that #24 has been merged, and MAT modularized, same effect can be now achieved by simply excluding the 3.0 module from dependencies.

But, my problem is not (only) this: MAT is half done (is unfinished) and if we stick with it, there will be probably someone who will try to "improve" its API, thus, we are again at doubling efforts as new Maven 4 API and MAT will become somewhat "competing" APIs.

This is why I think just detaching from MAT and leave it to oblivion is better, as for Maven 3.1-3.999 using eclipse resolver packages are completely okay, while in Maven 4 we will need to switch to new API anyway....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants