From c5fbd80078ea8e481984d499ceca106e4c55d8f5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Matthias=20B=C3=BCnger?= Date: Sat, 1 Aug 2026 11:46:52 +0200 Subject: [PATCH] Align PR template --- .github/pull_request_template.md | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index f08f18c1..51e18bc1 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,17 +1,15 @@ Following this checklist to help us incorporate your contribution quickly and easily: -- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MCHANGES) filed - for the change (usually before you start working on it). Trivial changes like typos do not - require a JIRA issue. Your pull request should address just this issue, without - pulling in other changes. -- [ ] Each commit in the pull request should have a meaningful subject line and body. -- [ ] Format the pull request title like `[MCHANGES-XXX] SUMMARY`, - where you replace `MCHANGES-XXX` and `SUMMARY` with the appropriate JIRA issue. -- [ ] Also format the first line of the commit message like `[MCHANGES-XXX] SUMMARY`. - Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message. +- [ ] Your pull request should address just one issue, without pulling in other changes. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. -- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. +- [ ] Each commit in the pull request should have a meaningful subject line and body. + Note that commits might be squashed by a maintainer on merge. +- [ ] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. + This may not always be possible but is a best-practice. +- [ ] Run `mvn verify` to make sure basic checks pass. + A more thorough check will be performed on your pull request automatically. +- [ ] You have run the integration tests successfully (`mvn -Prun-its verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure @@ -22,5 +20,4 @@ the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LI you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - -- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). \ No newline at end of file +- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).