Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MENFORCER-420] cache dependencies across rules #152

Conversation

josephw
Copy link
Contributor

@josephw josephw commented May 27, 2022

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MENFORCER-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MENFORCER-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@slawekjaranowski
Copy link
Member

slawekjaranowski commented May 29, 2022

Please

  • run mvn -Prun-its clean verify
  • squash to one final commit
  • put jira issue in brackets square in commit message

@josephw josephw force-pushed the MENFORCER-420-cache-dependencies-across-rules branch from 9682cbb to a1a3cd6 Compare May 29, 2022
@slawekjaranowski
Copy link
Member

slawekjaranowski commented May 30, 2022

GH builds special code PR+current master - after rebase with master I have the same strange error .... jdk 11

Caused by: java.lang.NullPointerException
    at com.sun.tools.javac.main.JavaCompiler.readSourceFile (JavaCompiler.java:841)
    at com.sun.tools.javac.processing.JavacProcessingEnvironment$ImplicitCompleter.complete (JavacProcessingEnvironment.java:1535)
    at com.sun.tools.javac.code.Symbol.complete (Symbol.java:642)

cause is missing dependencies for javax.annotation.Nonnull annotation.
Please check - I think that for private method we don't need such.

@slawekjaranowski slawekjaranowski self-assigned this May 30, 2022
@slawekjaranowski slawekjaranowski changed the title MENFORCER-420: cache dependencies across rules [MENFORCER-420] cache dependencies across rules May 30, 2022
…les.

Use an execution-scoped cache to store the results of the expensive call
to getDependenciesToCheck so that it's not recomputed for each rule.

Signed-off-by: Joseph Walton <jwalton@atlassian.com>
@josephw josephw force-pushed the MENFORCER-420-cache-dependencies-across-rules branch from a1a3cd6 to 2772fc2 Compare May 30, 2022
@josephw
Copy link
Contributor Author

josephw commented May 30, 2022

cause is missing dependencies for javax.annotation.Nonnull annotation. Please check - I think that for private method we don't need such.

Good call; dropped.

@slawekjaranowski slawekjaranowski merged commit f087e8e into apache:master May 31, 2022
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants