[MCOMPILER-178] add List parameter compilerArgs #4

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@jsievers

jsievers commented Feb 8, 2013

Add List parameter compilerArgs which only uses
values of configuration XML elements.
Deprecate Map parameter compilerArguments because

  1. it adds "-" in front of the key and "=" between key and value
    which is an implicit assumption on argument syntax that
    is generally is not desired
  2. ultimately since the XML element name is used as key,
    certain characters not allowed in XML element can't be used
    and there is no way to escape these characters in XML

The new parameter allows to escape unallowed XML
characters
e.g. using
since only the text body of the XML element is used as
argument to pass to the compiler.

[MCOMPILER-178] add List parameter compilerArgs
Add List parameter compilerArgs which only uses
values of configuration XML elements.
Deprecate Map parameter compilerArguments because
1. it adds "-" in front of the key and "=" between key and value
   which is an implicit assumption on argument syntax that
   is generally is not desired

2. ultimately since the XML element name is used as key,
   certain characters not allowed in XML element can't be used
   and there is no way to escape these characters in XML

The new parameter allows to escape unallowed XML
characters
e.g. using <![CDATA[my special weird non-XML valid
argument]]>
since only the text body of the XML element is used as
argument to pass to the compiler.
@olamy

This comment has been minimized.

Show comment Hide comment
@olamy

olamy Feb 8, 2013

Member

patch applied.
Thanks !
Can you close this pr ?

Member

olamy commented Feb 8, 2013

patch applied.
Thanks !
Can you close this pr ?

@jsievers

This comment has been minimized.

Show comment Hide comment
@jsievers

jsievers Feb 11, 2013

thanks!

thanks!

@jsievers jsievers closed this Feb 11, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment