This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
[MSHADE-182] Service file should be relocated. #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue when service file content is relocated, but file itself didn't. Patch content provided by some person in jira ticket.
|
cc @krosenvold |
|
+1 |
|
@Tibor17 never comment to commits, please comment on |
|
@Tibor17 how do you run build? All other errors failed the build before. Do you have some specific profiles? |
|
Ok, will try in-line variable. |
|
M.. no i can't... |
|
This |
|
@Tibor17 could you try yourself? :) |
|
This is the command I always verify before cutting the release version. See the site generated and test results of unit tests and integration tests. |
|
Unfortunately i have no java 1.6. |
|
If you make any updates in documentation, means src/site/, then you should check that with |
|
1.8 based build also enforces javadoc linting, i can't run mvn site, because this plugin has too ancient deps. |
|
java 1.7 works, i built site, opened index.html, navigate to checkstyle, it has 5 warnings for |
|
on java 1.6 Because it unavailable on mac os. |
|
on 1.6 for |
|
ok, mvn site is working. You should wait for developers who are actively On Thu, Jan 14, 2016 at 8:37 PM, Kanstantsin Shautsou <
Cheers |
|
Fixed in SVN r1728966 |
|
@aheritier cool, thanks! should i close PR? |
|
Hey @aheritier @KostyaSha! Could you please tell me in which release this PR will be available? |
|
I released my own fork and using it. I have no idea what is happening in slowpoke upstream. Maybe maven not alive. Also planning move to gradle. |
|
bouhhhh :( cc @rfscholte @hboutemy |
|
@aheritier @rfscholte @hboutemy Any news? |
|
@slaskawi you can use my bintray version if you want https://github.com/KostyaSha/yet-another-docker-plugin/blob/master/yet-another-docker-java/pom.xml#L23 (plus repo) |
|
@KostyaSha Thanks a lot for the offer but I applied a work around in Infinispan repository some time ago. I would like to remove it and implement it "properly" :) But again - thanks a lot! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue when service file content is relocated, but file itself didn't.
Patch content provided by some person in jira ticket.
https://issues.apache.org/jira/browse/MSHADE-182