MRELEASE-979 - use split policies #15
Conversation
Use different configuration settings for branch and tag naming. Add a second default policy that is used when naming branches.
- Ensure that the naming policy is executed when a branch is requested even if an scm tag name is set.
- Ensure that in non-interactive mode, the plugin does not fail unconditionally if a branch is requested.
| * | ||
| * @since 3.0.0 | ||
| */ | ||
| @Parameter( defaultValue = "default", property = "projectNamingPolicyId" ) | ||
| private String projectNamingPolicyId; | ||
| @Parameter( defaultValue = "default-branch", property = "projectBranchNamingPolicyId" ) |
There was a problem hiding this comment.
defaultValue should stay "default", property should stay "projectNamingPolicyId", since you will never run release:prepare and release:branch. Only the name of the field has to be different, so you can configure both inside your pom.
There was a problem hiding this comment.
If the default value is "default", then it selects the same policy as the default tag naming policy because there is only a single map with policies. That is the whole point of this change, as the default policy is different for tags (there it uses <artifact>-<version> if no tag was given) and branches (there it provides no default therefore a branch request fails if no name is given). As you insisted to moving this naming strategy into the DefaultNamingStrategy and refused any approach to separate those out, what is your suggestion to continue?
I am at a loss here. I am going back and forth through these changes and every time, you come back saying "this needs to be different, not this way". There are two default policies and you block any approach to acknowledge this fact.
|
closing, as some pieces have been merged as 8415f87 |
This is a rewrite of #14 to use split policies for branching and tagging as suggested by @rfscholte .