From cb7fb7690973907aa4ba9cce45af80c5cc164cc1 Mon Sep 17 00:00:00 2001 From: Tamas Cservenak Date: Fri, 14 Nov 2025 17:10:10 +0100 Subject: [PATCH 1/3] Bugfix: Java 25 broke test As test was naively using `new File("")` assuming its method `file.list()` will return `null` on cleanup in `teardown()` method. But, it turns out it was an old Java bug fixed in Java 25, and once GH matrix got Java 25 introduced, it broke the build. Refs: * https://bugs.openjdk.org/browse/JDK-8024695 * https://inside.java/2025/11/03/quality-heads-up/ Thanks to @sormuras --- .../aether/internal/impl/DefaultArtifactResolverTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/DefaultArtifactResolverTest.java b/maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/DefaultArtifactResolverTest.java index 3982807d9..024d6bf0e 100644 --- a/maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/DefaultArtifactResolverTest.java +++ b/maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/DefaultArtifactResolverTest.java @@ -761,7 +761,7 @@ public void testFindInLocalRepositoryWhenVersionWasFoundInLocalRepository() thro session.setLocalRepositoryManager(new LocalRepositoryManager() { public LocalRepository getRepository() { - return new LocalRepository(new File("")); + return new LocalRepository(lrm.getRepository().getBasedir()); } public String getPathForRemoteMetadata(Metadata metadata, RemoteRepository repository, String context) { @@ -828,7 +828,7 @@ public void testFindInLocalRepositoryWhenVersionRangeWasResolvedFromLocalReposit session.setLocalRepositoryManager(new LocalRepositoryManager() { public LocalRepository getRepository() { - return new LocalRepository(new File("")); + return new LocalRepository(lrm.getRepository().getBasedir()); } public String getPathForRemoteMetadata(Metadata metadata, RemoteRepository repository, String context) { From ab3352c9b6c695909943d07562d730133976efa1 Mon Sep 17 00:00:00 2001 From: Tamas Cservenak Date: Fri, 14 Nov 2025 17:34:39 +0100 Subject: [PATCH 2/3] Update CI --- .github/workflows/maven-verify.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/maven-verify.yml b/.github/workflows/maven-verify.yml index e9e5c9ea1..159dbdf35 100644 --- a/.github/workflows/maven-verify.yml +++ b/.github/workflows/maven-verify.yml @@ -26,7 +26,8 @@ jobs: name: Verify uses: apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v4 with: + ff-run: false ff-site-run: false - maven-matrix: '[ "3.9.9" ]' - - + maven-matrix: '[ "3.9.11" ]' + maven4-enabled: true + jdk-matrix: '[ "21", "25", "8" ]' From 6cfbce9313b85e829055f8626de568e8b0ad02d9 Mon Sep 17 00:00:00 2001 From: Tamas Cservenak Date: Fri, 14 Nov 2025 17:38:35 +0100 Subject: [PATCH 3/3] Use only needed ones --- .github/workflows/maven-verify.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/maven-verify.yml b/.github/workflows/maven-verify.yml index 159dbdf35..d6fd5a8f8 100644 --- a/.github/workflows/maven-verify.yml +++ b/.github/workflows/maven-verify.yml @@ -28,6 +28,6 @@ jobs: with: ff-run: false ff-site-run: false - maven-matrix: '[ "3.9.11" ]' maven4-enabled: true - jdk-matrix: '[ "21", "25", "8" ]' + verify-fail-fast: false +