Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSHADE-326] Hide shaded dependencies from the rest of the reactor build #26

Conversation

@nielsbasjes
Copy link

commented Aug 28, 2019

NOTE: This also includes the changes I created for MSHADE-36 in this pull request #25 !

Jira: https://issues.apache.org/jira/browse/MSHADE-326
In several multi module projects I have created I ran into the same problems with shading dependencies. See https://yauaa.basjes.nl/NOTES-shading-dependencies.html

This is a proposed change to fix those problems.

==============

Following this checklist to help us incorporate your contribution quickly and easily:

  • Jira: https://issues.apache.org/jira/browse/MSHADE-326
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like `[MSHADE-XXX] - ... '
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@khmarbaise

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

It's great that you created pull request but unfortunately you should make a separate PR for each JIRA you are trying to solve....also squash your commits into a single commit...that makes it easier to merge it and review it....many thanks for your support.

@nielsbasjes

This comment has been minimized.

Copy link
Author

commented Aug 28, 2019

Yes, normally I fully agree.
However in my opinion this fix is useless/meaningless without MSHADE-36 fix I created.
That is why I chose to make this a commit on top of that one.

@GigabyteProductions

This comment has been minimized.

Copy link

commented Aug 28, 2019

Squashing commits hides details of the history.

@GigabyteProductions

This comment has been minimized.

Copy link

commented Aug 28, 2019

... in addition to coupling otherwise independent commits, which hurts ability to cherry pick or rebase commits away before merge.

@khmarbaise

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

Have you taken a look in the apache maven projects? We use single commit setup and don't want to merge a number of 2-n commits into the history to fix/add a single feature. Single commits makes it easier to understand the history and make it easier to undo changes if needed....

Can you make the PR for MSHADE-36 (single commit) which means to be applied first and afterwards we can apply MSHADE-326 ....

@nielsbasjes

This comment has been minimized.

Copy link
Author

commented Aug 30, 2019

Working on it.

@nielsbasjes nielsbasjes force-pushed the nielsbasjes:MSHADE-326-Hide-shaded-dependencies-from-the-rest-of-the-reactor-build branch from 691331f to 75463c5 Aug 30, 2019

@nielsbasjes

This comment has been minimized.

Copy link
Author

commented Aug 30, 2019

I've updated #25 to be a single commit as requested.

Because these two changes are dependent this pull request will look like 'two commits' but it is actually a single commit that requires #25 to be already applied. I hope this is what you meant.

Please review (especially the code changes for both of these proposals themselves).

@nielsbasjes

This comment has been minimized.

Copy link
Author

commented Aug 30, 2019

FYI: I did some additional testing in my own project and these changes work as I expect them to work.
See: https://github.com/nielsbasjes/yauaa/tree/VerifyMSHADE36-MSHADE326

@nielsbasjes nielsbasjes force-pushed the nielsbasjes:MSHADE-326-Hide-shaded-dependencies-from-the-rest-of-the-reactor-build branch from 75463c5 to 8f3858b Aug 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.