Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https://issues.apache.org/jira/browse/SUREFIRE-1475 #174

Open
wants to merge 3 commits into
base: master
from

Conversation

@awallgren
Copy link

commented Feb 10, 2018

Don't assume wmic is on the path on windows.

Don't assume wmic is on the path on windows.
@Tibor17

This comment has been minimized.

Copy link
Contributor

commented Feb 10, 2018

Did we take right path here as well? Did Microsoft mention this link in their documentation?

@awallgren

This comment has been minimized.

Copy link
Author

commented Feb 10, 2018

@awallgren

This comment has been minimized.

Copy link
Author

commented Feb 10, 2018

@Tibor17

This comment has been minimized.

Copy link
Contributor

commented Feb 10, 2018

Logging errors can be added to the dump file, but right now please add the Microsoft link, as you said 'yes'.

@Tibor17

This comment has been minimized.

Copy link
Contributor

commented Feb 10, 2018

First of all do it similar like we do in *NIX.
Resolve %SystemRoot%\System32\Wbem\wmic.exe in Java and check that the file exists.
If it exists use it, otherwise do it as we did before.

@Tibor17

This comment has been minimized.

Copy link
Contributor

commented Feb 10, 2018

Of course you should push only single commit in PR.
git commit --amend
and the title must be
[SUREFIRE-1475] ...here is title as in Jira...

@Tibor17

This comment has been minimized.

Copy link
Contributor

commented Feb 14, 2018

@awallgren
Are you here?

@Tibor17

This comment has been minimized.

Copy link
Contributor

commented Mar 3, 2018

@awallgren
You can close this PR. There is already a branch with dedicated fix:
https://git-wip-us.apache.org/repos/asf?p=maven-surefire.git;a=shortlog;h=refs/heads/SUREFIRE-1475
Thx for contributing!

@Tibor17

This comment has been minimized.

Copy link
Contributor

commented Mar 18, 2018

@awallgren Close this pull request. It was released in Version 2.21.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.