New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-5961] Fix the SLF4J logger factory implementation used for LOG4J2 #104

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@aheritier

This comment has been minimized.

Show comment
Hide comment
@aheritier

This comment has been minimized.

Show comment
Hide comment
@aheritier

aheritier Jan 31, 2017

Contributor

I think @stephenc will tell me to push a branch on ASF side :-)

Contributor

aheritier commented Jan 31, 2017

I think @stephenc will tell me to push a branch on ASF side :-)

@michael-o

This comment has been minimized.

Show comment
Hide comment
@michael-o

michael-o Jan 31, 2017

Member

I am fine with this PR. You have to raise the issue on the dev mailing list to have at least someone who seconds it. If someone does, after your branch passes all tests, go ahead and merge into master.

Member

michael-o commented Jan 31, 2017

I am fine with this PR. You have to raise the issue on the dev mailing list to have at least someone who seconds it. If someone does, after your branch passes all tests, go ahead and merge into master.

@aheritier

This comment has been minimized.

Show comment
Hide comment
@aheritier

aheritier Jan 31, 2017

Contributor

@michael-o we don't have a CI validation here, thus I have to open a real branch on ASF side. Right ?

Contributor

aheritier commented Jan 31, 2017

@michael-o we don't have a CI validation here, thus I have to open a real branch on ASF side. Right ?

@michael-o

This comment has been minimized.

Show comment
Hide comment
@michael-o

michael-o Jan 31, 2017

Member

Do this:

git checkout master
git checkout -b MNG-5961
git cherry-pick <your-sha1>
git push

Wait for the Jenkins build to finish, get approval

git checkout master
git merge MNG-5961

Delete branch locally and remote.

Member

michael-o commented Jan 31, 2017

Do this:

git checkout master
git checkout -b MNG-5961
git cherry-pick <your-sha1>
git push

Wait for the Jenkins build to finish, get approval

git checkout master
git merge MNG-5961

Delete branch locally and remote.

@aheritier

This comment has been minimized.

Show comment
Hide comment
@aheritier

aheritier Jan 31, 2017

Contributor

Cool @michael-o it is exactly what I did
the build is in progress
https://builds.apache.org/view/Maven/job/maven-3.x-jenkinsfile/job/MNG-5961/

Contributor

aheritier commented Jan 31, 2017

Cool @michael-o it is exactly what I did
the build is in progress
https://builds.apache.org/view/Maven/job/maven-3.x-jenkinsfile/job/MNG-5961/

@stephenc

This comment has been minimized.

Show comment
Hide comment
@stephenc

stephenc Feb 1, 2017

Contributor

we don't have a CI validation here

Yep waiting to get SCM API 2.0.x back into the uc and then pester infra to upgrade

Contributor

stephenc commented Feb 1, 2017

we don't have a CI validation here

Yep waiting to get SCM API 2.0.x back into the uc and then pester infra to upgrade

@aheritier aheritier closed this Feb 5, 2017

@aheritier aheritier deleted the aheritier:patch-1 branch Feb 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment