[maven-4.0.x] Backport bug fixes from #11741 and #11733#12144
Merged
Conversation
The validateProfileId() method was missing a null check before calling validProfileIds.contains(id). Since validProfileIds uses ConcurrentHashMap.newKeySet() which doesn't allow null keys, a null profile ID would cause a NullPointerException instead of a proper validation error. This makes validateProfileId() consistent with validateCoordinateId() which already has the null check. Fixes #11740 Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
* fix: error == null to error != null in isError * feat: add regresion test
|
@gnodet Please assign appropriate label to PR according to the type of change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backports two bug fixes from
mastertomaven-4.0.x:validateProfileId():ConcurrentHashMap.newKeySet().contains(null)throws NPE. Adds null guard consistent withvalidateCoordinateId().isError()inArtifactMetadata: returnedtruewhenerror == null(no error) andfalsewhen an error was set — exactly backwards.Both cherry-picks applied cleanly with no conflicts.
Test plan
maven-4.0.xClaude Code on behalf of Guillaume Nodet