Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-6581] - Update to latest Modello plugin version #252

Closed
wants to merge 1 commit into from

Conversation

oehme
Copy link
Contributor

@oehme oehme commented Jun 3, 2019

Follow-up to codehaus-plexus/modello#31

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MNG-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@olamy
Copy link
Member

olamy commented Jun 3, 2019

we might need a Jira here :)

@oehme oehme changed the title Update to latest Modello plugin version [MNG-6581] - Update to latest Modello plugin version Jun 3, 2019
@oehme
Copy link
Contributor Author

oehme commented Jun 3, 2019

Done :)

@olamy
Copy link
Member

olamy commented Jun 3, 2019

thanks!
pushed in branch MNG-6581 let's see what CI says
https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven/job/MNG-6581/

pom.xml Show resolved Hide resolved
@michael-o
Copy link
Member

@rfscholte @khmarbaise Can someone push a new Modello release?

@olamy
Copy link
Member

olamy commented Jun 9, 2019

oops sorry I will do that now

@olamy
Copy link
Member

olamy commented Jun 10, 2019

@oehme modello 1.11 released please update the pr.

asfgit pushed a commit that referenced this pull request Jun 10, 2019
@michael-o
Copy link
Member

ITs are running...

@asfgit asfgit closed this in 5035837 Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants