Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

METRON-1867 Remove `/api/v1/update/replace` endpoint #1284

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
3 participants
@nickwallen
Copy link
Contributor

commented Nov 29, 2018

The /api/v1/update/replace endpoint is no longer used. This is dead code and should be removed.

I have tried to isolate the changes from #1259 on to master to help reviewers. This replaces #1259.

Testing

  1. Spin-up Full Dev.
  2. Open the Alerts UI.
    • View alerts.
    • Escalate an alert.
    • Comment on an alert.
    • Create a meta-alert.
    • Escalate a meta-alert.
  3. Run the UI e2e tests.

Pull Request Checklist

  • Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
  • Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
  • Has your PR been rebased against the latest commit within the target branch (typically master)?
  • Have you included steps to reproduce the behavior or problem that is being changed or addressed?
  • Have you included steps or a guide to how the change may be verified and tested manually?
  • Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
  • Have you written or updated unit tests and or integration tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

@nickwallen nickwallen referenced this pull request Nov 29, 2018

Closed

METRON-1867 Remove `/api/v1/update/replace` endpoint #1259

10 of 12 tasks complete
@sardell

This comment has been minimized.

Copy link
Contributor

commented Nov 30, 2018

Though I cannot vouch for the Java changes, the UI builds and runs fine. It looks like the only change needed there is the removal of the replace request model since, as you pointed out, there were no calls being made to the replace endpoint.

@mmiklavc

This comment has been minimized.

Copy link
Contributor

commented Dec 4, 2018

+1 by inspection pending details on the following:

  • Is this endpoint superseded by another implementation, or just removed altogether?
  • Any users of the REST API using this directly for any reason? Not sure if we have to deprecate this - i.e. I'm unclear of whether or not we consider the REST API client facing or not, or if it's just middleware to us for the UI.
@nickwallen

This comment has been minimized.

Copy link
Contributor Author

commented Dec 4, 2018

Is this endpoint superseded by another implementation, or just removed altogether?

The endpoint has been removed completely. It is not being used by anything in Metron currently.

Any users of the REST API using this directly for any reason? Not sure if we have to deprecate this - i.e. I'm unclear of whether or not we consider the REST API client facing or not, or if it's just middleware to us for the UI.

I just sent out a notice to the dev list to see if anyone has a strong opinion.

@asfgit asfgit closed this in 285ba5e Dec 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.