Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

METRON-1521: JSONMapParser is no longer serializable #991

Closed

Conversation

@cestella
Copy link
Member

commented Apr 11, 2018

Contributor Comments

Currently the JSONMapParser does not function because an anonymous inner class (TypeRef) is not serializable.

  • Create a new parser by editing $METRON_HOME/config/zookeeper/parsers/dummy.json to have the following content:
{
  "parserClassName":"org.apache.metron.parsers.json.JSONMapParser",
  "sensorTopic":"dummy",
  "fieldTransformations" : [
         { "transformation" : "STELLAR"
         ,"output" : [ "new_field"]
         ,"config" : {
           "new_field" : "JOIN( [ TO_UPPER(source.type), field ], ',' )"
                     }
         }
  ]
}
  • Create the dummy kafka topic via /usr/hdp/current/kafka-broker/bin/kafka-topics.sh --zookeeper node1:2181 --create --topic dummy --partitions 1 --replication-factor 1
  • Push the zookeeper configs via $METRON_HOME/bin/zk_load_configs.sh --mode PUSH -i $METRON_HOME/config/zookeeper -z node1:2181
  • Start the parser via $METRON_HOME/bin/start_parser_topology.sh -k node1:6667 -z node1:2181 -s dummy
  • Create some dummy data by creating a file at ~/dummy.dat with the following:
{ "field" : "f1", "source.type" : "dummy" }
{ "field" : "f2", "source.type" : "dummy" }
{ "field" : "f3", "source.type" : "dummy" }
{ "field" : "f4", "source.type" : "dummy" }
{ "field" : "f5", "source.type" : "dummy" }
{ "field" : "f6", "source.type" : "dummy" }
{ "field" : "f7", "source.type" : "dummy" }
  • Send the dummy data in via cat ~/dummy.dat | /usr/hdp/current/kafka-broker/bin/kafka-console-producer.sh --broker-list node1:6667 --topic dummy
  • Ensure the data written to the indices has a field new_field that looks like DUMMY,${field}

Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.

In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:

For all changes:

  • Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
  • Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
  • Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

  • Have you included steps to reproduce the behavior or problem that is being changed or addressed?

  • Have you included steps or a guide to how the change may be verified and tested manually?

  • Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:

    mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh 
    
  • Have you written or updated unit tests and or integration tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

  • Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via site-book/target/site/index.html:

    cd site-book
    mvn site
    

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.

@cestella cestella referenced this pull request Apr 11, 2018
10 of 10 tasks complete
cestella added a commit to cestella/incubator-metron that referenced this pull request Apr 11, 2018
@ottobackwards

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2018

+1 thanks for the fix

@asfgit asfgit closed this in eb5b2d4 Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.