[SSHD-393] Fix frozen ssh output stream on window adjust #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When sending large amount of data, usually more than 2 mb, for output stream, server wrote delayed write and is not awakened after command SSH_MSG_CHANNEL_WINDOW_ADJUST. Problem tested with JUnit test, so this test can be attached or sent when requested. |
When server output stream delayed write it did not resume it after the window was adjusted Resume writes the same way client ssh channel does Added 2 unit tests to verify the fix
marosmars
changed the title
|
marosmars could you also attach unit test? |
|
The unit tests are already there. I can see them within the commit |
|
Could you please close this PR now ? |
|
Done. Thx |
|
Very soon, I'm mainly waiting for a confirmation that SSHD-348 is fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When server output stream delayed write it did not resume it after the window was adjusted
Resume writes the same way client ssh channel does
maros.mars@gmail.com