Permalink
Browse files

EXTCDI-288 set isUnknownWindowIdsAllowed to true as default

git-svn-id: https://svn.apache.org/repos/asf/myfaces/extensions/cdi/trunk@1338150 13f79535-47bb-0310-9956-ffa450edef68
  • Loading branch information...
struberg committed May 14, 2012
1 parent ad8c264 commit 5f27b2a1cf47985bc5a1ff9b4452e95cdf496170
@@ -52,17 +52,29 @@ public boolean isUrlParameterSupported()
/**
* Allows to restrict window-ids.
- * With the default window handler (esp. for JSF 1.2), URLs have to contain the window-id.
+ * <p>With the default window handler (esp. for JSF 1.2), URLs have to contain the window-id.
* If users bookmark these links, they could open 2-n tabs (with the bookmark) which have the same window-id.
- * It isn't possible to prevent it if the session is still active, but it's possible to prevent it as soon as the
- * session gets closed.
+ * It is only possible to prevent it if the ClientSideWindowHandler is used.
+ * </p>
*
- * @return true to allow window-ids which aren't generated by CODI, false otherwise
+ * <p><b>ATTENTION:</b> Since CODI-1.0.6 this is set to <code>true</code> as defalt!</p>
+ *
+ * <p>
+ * This must be enabled to
+ * <ul>
+ * <li>allow <i>target</i> attributes in a href</li>
+ * <li>support multiple webapps in an EAR scenario. Since each webapp has it's own session,
+ * they would otherwise trash their windowIds each time you link from one webapp to another one</li>
+ * <li>play nicely with other frameworks which use the window.name for browser tab detection</li>
+ * </ul>
+ * </p>
+ * @return <code>true</code> to allow all windowIds already present in window.name.
+ * <code>false</code> to only allow window-ids which are generated by CODI
*/
@ConfigEntry
public boolean isUnknownWindowIdsAllowed()
{
- return false;
+ return true;
}
/**

0 comments on commit 5f27b2a

Please sign in to comment.