Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hw/drivers/sx1272: Make driver shield compatible and fix driver issues. #865

Merged
merged 1 commit into from Mar 6, 2018

Conversation

wes3
Copy link
Contributor

@wes3 wes3 commented Mar 2, 2018

The main changes in this commit were to make all GPIO that interface
the chip to the MCU MYNEWT_VALs so they can be configured either
in a target or bsp. This makes creating a bsp + shield combo
simple by defining the interface GPIO in a target.

Some additional fixes/changes are in this commit such as:

  1. Using the proper reset sequence.
  2. Fixing a bug with the spi/read write command.
  3. Adding a MYNEWT_VAL to select a separate spi routine to be
    used to read/write buffers to the chip. The blocking,
    byte-by-byte hal spi api is not working on the 52840
    when combined with the sx1272 for some reason so this is a
    temporary work-around.

The main changes in this commit were to make all GPIO that interface
the chip to the MCU MYNEWT_VALs so they can be configured either
in a target or bsp. This makes creating a bsp + shield combo
simple by defining the interface GPIO in a target.

Some additional fixes/changes are in this commit such as:
1) Using the proper reset sequence.
2) Fixing a bug with the spi/read write command.
3) Adding a MYNEWT_VAL to select a separate spi routine to be
used to read/write buffers to the chip. The blocking,
byte-by-byte hal spi api is not working on the 52840
when combined with the sx1272 for some reason so this is a
temporary work-around.
@sterlinghughes sterlinghughes merged commit 00f9a84 into apache:master Mar 6, 2018
@wes3 wes3 deleted the sx1272_shield branch March 6, 2018 19:45
@aditihilbert aditihilbert added this to the 1.4.0 milestone Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants