mesh: Fix possible race condition and other issues #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjanc
approved these changes
Apr 9, 2018
michal-narajowski
force-pushed
the
mesh_cli
branch
from
e85fe18
to
c8ba82b
Compare
michal-narajowski
changed the title
added 4 commits
April 10, 2018 12:32
It's not always guaranteed that param->status will be non-NULL, especially not after a subsequent patch to fix a race condition with the response waiting.
If the thread that sends the configuration messages has low priority and is sending to the local node (a common use case currently) it's possible that the response arrives before the cli->op_* state variables are set, resulting in the message never getting properly processed and the client API call timing out. Split the initialization into a separete cli_prepare() call and add a cli_reset() to clean up the variables in case of premature completion of the client operation (e.g. due to message sending failure).
There's a small but real chance of a race-condition when sending messages to the local node (through the local network interface) that expected parameters will be NULL in the message handles. Add appropriate NULL checks for them.
The Node Identity advertising should only be automatically enabled when provisioning happened over PB-GATT, but not when it happened over PB-ADV. Move the enabling of Node Identity to the provisioning code, where we know the bearer that was used (this information does not get passed to the bt_mesh_provision function).
michal-narajowski
force-pushed
the
mesh_cli
branch
from
c8ba82b
to
31663a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a small but real chance of a race-condition when sending
messages to the local node (through the local network interface) that
expected parameters will be NULL in the message handles. Add
appropriate NULL checks for them.
Fix Node Identity advertising with PB-ADV:
The Node Identity advertising should only be automatically enabled when provisioning happened over PB-GATT, but not when it happened over PB-ADV. Move the enabling of Node Identity to the provisioning code, where we know the bearer that was used (this information does not get passed to the bt_mesh_provision function).