Make @JavaScriptResource repeatable #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit d5aa0b8ee modifies Bck2Brwsr to support |
|
+1 This change would be very helpful, and it also provides a simple way of establishing an order of JS resources. Without this change it's a tedious and error prone task to setup the individual files and establish the load order via JSBody. (Toni Epple) |
|
OK, thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some people, for example Toni Epple, complained that it is hard to load multiple JavaScript files at once with
@JavaScriptResourceannotation. This can easily be fixed by making it@Repeatable. The change to API is minimal, the implementation is simple.The biggest challenge will be for guys with non-JVM implementations of the
@JavaScriptResource- e.g. Bck2Brwsr and TeaVM. But it shall be possible to handle the change, right @konsoletyper?