Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make @JavaScriptResource repeatable #4



Copy link

Some people, for example Toni Epple, complained that it is hard to load multiple JavaScript files at once with @JavaScriptResource annotation. This can easily be fixed by making it @Repeatable. The change to API is minimal, the implementation is simple.

The biggest challenge will be for guys with non-JVM implementations of the @JavaScriptResource - e.g. Bck2Brwsr and TeaVM. But it shall be possible to handle the change, right @konsoletyper?

Copy link

jtulach commented Dec 28, 2017

Commit d5aa0b8ee modifies Bck2Brwsr to support JavaScriptResource.Group annotation.

Copy link

+1 This change would be very helpful, and it also provides a simple way of establishing an order of JS resources. Without this change it's a tedious and error prone task to setup the individual files and establish the load order via JSBody. (Toni Epple)

Copy link

OK, thanks for the review.

@JaroslavTulach JaroslavTulach merged commit 25fa0fa into apache:master Jan 4, 2018
@JaroslavTulach JaroslavTulach deleted the jtulach/MultiJavaScriptResource branch January 4, 2018 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
3 participants