Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow VSCode users to choose 'local' - e.g. per workspace userdir #3308

Merged

Conversation

JaroslavTulach
Copy link

Some users of VSNetBeans complained that Language server in VSCode is mixing contents from different workspaces.

Sometimes I work with two checkouts of our repos, e.g. one on a brach that I'm currently actively working on,
and a second one to produce quick fixes, or to babysit a merge.

If I open both workspaces at the same time, then the language server seems to mix up the symbols from
the two workspaces.

... searching for a class finds two copies. The second one (located in src/...) is the correct one from this workspace.
The first one (located in ~/git/.../...) is from another workspace. In the second workspace it's the other way round
(i.e. the first one is correct and shows a project name, the second one shows a full path and is from the other workspace).

Closing the other workspace does not fix the issue, but restarting vscode does.

This PR offers the user to choose between global and local workspace. By using local one gets new instance of the NetBeans Language server backend per each workspace.

@JaroslavTulach JaroslavTulach self-assigned this Nov 8, 2021
@JaroslavTulach JaroslavTulach added this to the 13 milestone Nov 8, 2021
@JaroslavTulach JaroslavTulach merged commit fa97c0c into apache:master Nov 8, 2021
@junichi11 junichi11 added LSP [ci] enable Language Server Protocol tests VSCode Extension [ci] enable VSCode Extension tests labels Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LSP [ci] enable Language Server Protocol tests VSCode Extension [ci] enable VSCode Extension tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants