Editor deadlock and null pointer exception while parsing java file

[smil2k]

Apache NetBeans version

Apache NetBeans 13

What happened

Pressing ctrl-space for suggestions leaves the editor in a freezing state.

Stacktrace reveals that in case the java source cannot be parsed, then the basedocument "loses" the write lock.

How to reproduce

I pressed ctrl-space in the attached source file.

Did this work correctly in an earlier version?

No

Operating System

Linux

JDK

11.0.15+10-Ubuntu-0ubuntu0.20.04.1

Apache NetBeans packaging

Apache NetBeans binary zip

Anything else

Reproduced 3 times in a row.

Are you willing to submit a pull request?

No

Code of Conduct

Yes

[smil2k]

messages.log

[mbien]

@smil2k i believe you forgot to attach the java file. If it doesn't work paste it into a code section assuming its not too big, would be great to have a small, self-contained reproducer if possible.

[smil2k]

SchedClassicScheduleLoader_66.dump.txt

[smil2k]

@mbien The most important part for me is that in this case the editor stuck, all files left unsaved.

The fact that code complete did not work is secondary.

[mbien]

I took the class from the dump file and could edit it in NetBeans 13. Autocompletion worked too on the few fields which can be resolved.

[smil2k]

z.zip
This is the set of files produced by the series of null pointers.

The problem happened, when I rewrote repository to repo (so the type became available) then the "No suggestion" tooltip shown and the editor stuck.

[mbien]

NPEs in javac can be caused by a lot of things. Since I can't reproduce this (not even the exceptions), the most likely explanation is lombok.

A thread dump would show if its actually a deadlock or something else (e.g an infinite loop). You could also check if its reproducible in NetBeans 14rc3 since it uses a javac library based on JDK 18 (https://lists.apache.org/thread/m56qct2ksl210rr1hpdvcgcsydxnyg9c ).

[smil2k]

Ok, no worries.

I've attached the stackdump from the locked up editor, could you please check that also?
I'm more interested in the deadlock part, I got used to null pointer in javac. Code complete often fails with closures.

Somehow this null pointer could leave the document in a write locked state.

[mbien]

Uploading deadlock2.txt…

@smil2k this link does not work.

[smil2k]

deadlock2.txt

[smil2k]

@mbien I was not able to save the file either, only after fixing an import problem the whole thing started to work again.