maven project compile args not passed to editor javac #1173
Conversation
| if (ARG_PARAMETERS.equals(compilerArg.trim())) { | ||
| return Arrays.asList(ARG_PARAMETERS);//reqd? | ||
| } | ||
| return Arrays.asList(compilerArgs); |
There was a problem hiding this comment.
I don't see the point of this loop. Currently the code results in returning the full list of arguments, if at least one parameter is not null. I tried to provoke a NULL value in the arguments list. None of these variants resulted in a null value:
<arg></arg>
<arg/>
<arg xsi:nil="true" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"/>So I would propose to return the argument list, if it is not null directly.
| return Arrays.asList(ARG_PARAMETERS); | ||
| if (compilerArg != null) { | ||
| if (ARG_PARAMETERS.equals(compilerArg.trim())) { | ||
| return Arrays.asList(ARG_PARAMETERS);//reqd? |
There was a problem hiding this comment.
In the original code there are only two cases:
- if a compiler argument
-parameterswas provided, it will be returned - else an empty list is returned
This makes sense reading the commit message of the addition:
http://hg.netbeans.org/main-golden/log/tip/maven/src/org/netbeans/modules/maven/queries/PomCompilerOptionsQueryImpl.java
It is basicly a guard to limit the change to that single parameter.
There was a problem hiding this comment.
Thanks, removed special handling for -parameters here.
|
validateCompilerOptions removes any unsupported parameters. |
No description provided.