Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PHP samples #1183

Merged
merged 5 commits into from Apr 2, 2019

Conversation

@junichi11
Copy link
Member

commented Apr 2, 2019

  • Fix emails of composer.json
  • Fix copyright footers from Oracle to The ASF
  • Change the PHP version to 7.3
  • Update require-dev
  • Remove description for Skeleton Generator because it has been abandoned
  • Add CalculatorTest.php to the PHPUnit sample

junichi11 added some commits Apr 2, 2019

Update Calculator-PHPUnit
- Update require-dev
- Remove description for Skeleton Generator because it has been abandoned
- Add CalculatorTest.php

@junichi11 junichi11 added the PHP label Apr 2, 2019

@junichi11 junichi11 requested a review from tmysik Apr 2, 2019

@tmysik

tmysik approved these changes Apr 2, 2019

@tmysik tmysik merged commit f91339e into apache:master Apr 2, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@junichi11 junichi11 deleted the junichi11:php-samples branch Apr 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.