Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NETBEANS-1696] PHP 7.4 Support #1199

Merged
merged 1 commit into from May 8, 2019

Conversation

@junichi11
Copy link
Member

commented Apr 13, 2019

https://issues.apache.org/jira/browse/NETBEANS-1696

  • Null Coalescing Assignment Operator part
  • Fix the parser and the lexer
  • Add unit tests for formatter, parser, and lexer
  • Add 7.4 to PhpVersion

Not Yet

@junichi11 junichi11 added the PHP label Apr 13, 2019

@junichi11

This comment has been minimized.

Copy link
Member Author

commented Apr 20, 2019

I've investigated a bit. It seems that unit tests fail after this commit: 3357fa5

Unit tests passed when I've checkout 123f616 (previous commit)
e.g.

Note

Unit tests fail even if I install the Oracle JS Parser.

@sdedic
Do you have any ideas to fix this problem?

@junichi11

This comment has been minimized.

Copy link
Member Author

commented Apr 20, 2019

I've submitted the problem to the JIRA: https://issues.apache.org/jira/browse/NETBEANS-2437

[NETBEANS-1696] PHP 7.4 Support
- Null Coalescing Assignment Operator part
- Fix the parser and the lexer
- Add unit tests for formatter, parser, and lexer
- Add 7.4 to PhpVersion

@junichi11 junichi11 marked this pull request as ready for review May 8, 2019

@junichi11 junichi11 force-pushed the junichi11:php7.4-support branch from 6ccf015 to f1637e4 May 8, 2019

@junichi11

This comment has been minimized.

Copy link
Member Author

commented May 8, 2019

The unit test problem was fixed :)

@junichi11 junichi11 requested a review from tmysik May 8, 2019

@tmysik

tmysik approved these changes May 8, 2019

Copy link
Member

left a comment

Nicely done, as always!

@tmysik tmysik merged commit ed85968 into apache:master May 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@junichi11 junichi11 deleted the junichi11:php7.4-support branch May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.