Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popupswitcher npe fixes #1219

Merged
merged 2 commits into from Apr 27, 2019

Conversation

@timboudreau
Copy link
Contributor

commented Apr 26, 2019

The attached patch fixes two rare but irritating NPEs from the popup switcher: If enough files are open that the popup switcher has two columns, but there is an odd number of files open, then the final item in the right column of the table has no item - but the code assumed it would always be non-null, so hovering or clicking the close button area on that spot generates a NullPointerException.

@geertjanw

This comment has been minimized.

Copy link
Member

commented Apr 26, 2019

Great, thanks!

@matthiasblaesing

This comment has been minimized.

Copy link
Contributor

commented Apr 27, 2019

I was able to reproduce the problem and verified the fix. The code change looks sane. Will merge. Thank you!

@matthiasblaesing matthiasblaesing merged commit cf1bd51 into apache:master Apr 27, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.