Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NETBEANS-2506] Added OpenJFX Samples module to JavaFX cluster. #1241

Merged
merged 1 commit into from Jun 14, 2019

Conversation

@jperedadnr
Copy link
Contributor

commented May 9, 2019

This PR adds two Maven samples that show how to run JavaFX 11+ (with or without FXML), with the JavaFX Maven plugin.

jose.pereda
@JaroslavTulach

This comment has been minimized.

Copy link
Contributor

commented May 10, 2019

Wouldn't it be better to extract the project skeleton from a Maven archetype? CCing @eppleton ...

@jperedadnr

This comment has been minimized.

Copy link
Contributor Author

commented May 10, 2019

Actually the two samples in the PR are just the application of the JavaFX Maven archetypes, and these can be easily generated via New Project -> Java with Maven -> Project from Archetype, selecting either of the two existing archetypes. This is also well documented here: https://openjfx.io/openjfx-docs/#IDE-NetBeans (Maven sections).

However, the purpose of this PR is to "bundle the Open JFX NetBeans samples", so while these two samples are the same anyone could generate via archetypes or via the OpenJFX samples repository, the user will get them ready to use from New Project -> Samples.

What's more, these samples are a little bit more integrated with NetBeans (they contain custom nbactions that override run and debug default actions).

@geertjanw

This comment has been minimized.

Copy link
Member

commented May 10, 2019

Makes sense to me, and many thanks for this contribution from Gluon, may there be more!

@jtulach

This comment has been minimized.

Copy link
Contributor

commented May 10, 2019

Makes sense to me, and many thanks for this contribution from Gluon, may there be more!

@geertjanw, I understand that you are excited seeing new contributor. Actually I am as well. Welcome José.

That however doesn't mean that the contribution make sense to me.

... just the application of the JavaFX Maven archetypes,

Good. There is an archetype.

via New Project -> Java with Maven -> Project from Archetype,

I see. This is not the most straightforward way to integrate a technology into NetBeans. JavaFX indeed deserves a better wizard!

However, the purpose of this PR is to "bundle the Open JFX NetBeans samples", so while these two samples are the same anyone could generate via archetypes or via the OpenJFX samples repository, the user will get them ready to use from New Project -> Samples.

There already is "New Project/Java with Maven/JavaFX Application" - why don't you rather fix/modify that one to be a nice UI over the archetypes? NetBeans has a nice support for creating wizards over Maven archetypes. I suggest to use it.

What's more, these samples are a little bit more integrated with NetBeans (they contain custom nbactions that override run and debug default actions).

I'd suggest to put those files into the archetypes. Unless I am mistaken @eppleton does that for the DukeScript archetypes. Unacceptable? Even if hidden by a archetype property?

José, please don't let me discourage you. We need Gluon to polish the JavaFX integration in NetBeans. I just want to do it the right "Maven (UI) way". I'd like NetBeans to be the UI for Maven - e.g. just a wizard that harnesses Maven and its archetypes.

@geertjanw

This comment has been minimized.

Copy link
Member

commented Jun 13, 2019

I propose we go ahead with this pull request and open a new issue for the better approach described by @jtulach. If no problem with this in 24 hours, I will merge this.

@geertjanw

This comment has been minimized.

Copy link
Member

commented Jun 14, 2019

OK, merging.

@geertjanw geertjanw merged commit 340934e into apache:master Jun 14, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@neilcsmith-net

This comment has been minimized.

Copy link
Member

commented Aug 11, 2019

(as I was adding a similar comment on something else)

If these stay as is for 11.2 then we need to fix master in the same way as 11.1 for these to actually work - see mailing list thread at https://lists.apache.org/thread.html/69de8f6e1cdcfcc65b0c92a81ea9c3724058b89e5a56adea0b3d79cd@%3Cdev.netbeans.apache.org%3E Or we replace as suggested above?

@junichi11 junichi11 modified the milestone: 11.2 Aug 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.