Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[NETBEANS-2506] Added OpenJFX Samples module to JavaFX cluster. #1241
Actually the two samples in the PR are just the application of the JavaFX Maven archetypes, and these can be easily generated via
However, the purpose of this PR is to "bundle the Open JFX NetBeans samples", so while these two samples are the same anyone could generate via archetypes or via the OpenJFX samples repository, the user will get them ready to use from
What's more, these samples are a little bit more integrated with NetBeans (they contain custom nbactions that override
@geertjanw, I understand that you are excited seeing new contributor. Actually I am as well. Welcome José.
That however doesn't mean that the contribution make sense to me.
Good. There is an archetype.
I see. This is not the most straightforward way to integrate a technology into NetBeans. JavaFX indeed deserves a better wizard!
There already is "New Project/Java with Maven/JavaFX Application" - why don't you rather fix/modify that one to be a nice UI over the archetypes? NetBeans has a nice support for creating wizards over Maven archetypes. I suggest to use it.
I'd suggest to put those files into the archetypes. Unless I am mistaken @eppleton does that for the DukeScript archetypes. Unacceptable? Even if hidden by a archetype property?
José, please don't let me discourage you. We need Gluon to polish the JavaFX integration in NetBeans. I just want to do it the right "Maven (UI) way". I'd like NetBeans to be the UI for Maven - e.g. just a wizard that harnesses Maven and its archetypes.
(as I was adding a similar comment on something else)
If these stay as is for 11.2 then we need to fix master in the same way as 11.1 for these to actually work - see mailing list thread at https://lists.apache.org/thread.html/69de8f6e1cdcfcc65b0c92a81ea9c3724058b89e5a56adea0b3d79cd@%3Cdev.netbeans.apache.org%3E Or we replace as suggested above?