Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NETBEANS-2004] Initial support for modular java project in Gradle #1276

Merged
merged 4 commits into from Jun 4, 2019

Conversation

@lkishalmi
Copy link
Contributor

commented May 31, 2019

I've tried to mimic the magic what Maven does (without all the functional bells and whistles). I feel some classpath definitions redundant however. As far as I could test it works and does not break existing classpath implementations.

Yes, unit-tests are missing.

@geertjanw, @jlahoda feel free add more reviewers if you know someone more knowledgeable.

@lkishalmi lkishalmi requested review from jlahoda and geertjanw May 31, 2019

@geertjanw
Copy link
Member

left a comment

Great from my point of view.

@geertjanw geertjanw added the NB11.1 label Jun 4, 2019

@lkishalmi lkishalmi merged commit c90f7cd into apache:master Jun 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.