Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NETBEANS-2646] Improve tabcontrol border appearance (HiDPI) #1284

Merged
merged 1 commit into from Jun 13, 2019

Conversation

@eirikbakke
Copy link
Contributor

commented Jun 6, 2019

This patch improves the appearance of various main window borders under fractional HiDPI scaling factors (e.g. 150%). This applies only on Windows for now. See https://issues.apache.org/jira/browse/NETBEANS-2646 .

This PR does not depend on any of the other HiDPI-related PRs.

See the attached screenshots (view at 100% scaling).
BordersBeforePatch
BordersAfterPatch

@geertjanw

This comment has been minimized.

Copy link
Member

commented Jun 13, 2019

Neat. Any reason not to merge this? Feel free to merge this yourself, unless you are convinced a review is needed first.

@eirikbakke

This comment has been minimized.

Copy link
Contributor Author

commented Jun 13, 2019

This one's low-risk, applies only to Windows 10, which I have tried it on, and any bugs are likely to be purely cosmetic in nature. Merging after reading through it once again myself....

@eirikbakke eirikbakke merged commit af00a5b into apache:master Jun 13, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.