Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NETBEANS-2457]: Provided Error Hint to turn on Preview Features in ant/maven Java projects #1285

Merged
merged 3 commits into from Jul 3, 2019

Conversation

@arusinha
Copy link
Contributor

commented Jun 7, 2019

Provided error fix for below kind of error in Java ant/maven projects. The fix will word on any preview features added in the jdk.

switch expressions are a preview feature and are disabled by default.
(use --enable-preview to enable switch expressions)

Issue Link:
https://issues.apache.org/jira/browse/NETBEANS-2457

Test Cases were not added as currently couldn't find support to create ant/maven project through code in Test Base classes of java.hints module

@jlahoda
Copy link
Contributor

left a comment

I don't think java.hints should depend directly on project type implementations. Please use maven.hints and either a new module for ant-based project, or write the impl in java.hints for ant so that it does not need the hard dependency on project.ant.

@arusinha arusinha added NB11.1 and removed work-in-progress labels Jun 18, 2019

@neilcsmith-net

This comment has been minimized.

Copy link
Member

commented Jun 18, 2019

Theoretically we're past feature freeze for NB 11.1. I'll let @jlahoda comment on whether we should allow through or retarget for NB 11.2.

@arusinha arusinha added NB11.2 and removed NB11.1 labels Jun 18, 2019

@geertjanw

This comment has been minimized.

Copy link
Member

commented Jun 20, 2019

It would be nice to have this one in nb11.1, because it is a good supporting feature for the various preview features we have in 11.1 (and also in 11.0), i.e., it simplifies their enablement. But if this makes it in in 11.2, that's also fine, no prob at all.

@arusinha

This comment has been minimized.

Copy link
Contributor Author

commented Jun 20, 2019

@jlahoda I had addressed all the review comment. Request you to review

@neilcsmith-net

This comment has been minimized.

Copy link
Member

commented Jul 3, 2019

@jlahoda merging this for NB11.1-beta3. I believe all changes requested have been made? Please raise concerns if required before the voting candidate is built so can be addressed or reverted. Thanks.

@neilcsmith-net neilcsmith-net merged commit f98af58 into apache:master Jul 3, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.