Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NETBEANS-2654] Add debugger support for Gradle Web Projects #1289

Merged
merged 3 commits into from Jun 15, 2019

Conversation

@lkishalmi
Copy link
Contributor

commented Jun 9, 2019

No description provided.

@lkishalmi lkishalmi requested review from JaroslavTulach and geertjanw Jun 9, 2019

* to the project. This is essentially the same as MavenDebugger for Maven
* projects.
*/
public interface GradleJavaDebugger {

This comment has been minimized.

Copy link
@JaroslavTulach

JaroslavTulach Jun 10, 2019

Contributor

Increment module version in manifest.mf. Add @since tag. Put an entry to apichanges.xml.

This comment has been minimized.

Copy link
@lkishalmi

lkishalmi Jun 10, 2019

Author Contributor

Thank you for that! Just a question on the spec version, after release it bumped from 1.0 to 1.1 on master. So spec version 1.1 is not yet released, do I still need to increase that number?

This comment has been minimized.

Copy link
@JaroslavTulach

JaroslavTulach Jun 12, 2019

Contributor

Depends on how precise you want to be? Users of our official releases will be OK with both choices. However if you had users updating NBMs from our daily builder, then they would already have version 1.1 without your API changes - if only the module using the new API was updated, then they wouldn't link properly. I am usually increasing the specification version for every API change.

PS: Dependencies of modules that require the new API should of course be updated as well.

@junichi11 junichi11 added the Gradle label Jun 11, 2019

@geertjanw

This comment has been minimized.

Copy link
Member

commented Jun 14, 2019

Ready to merge this for 11.1?

@lkishalmi

This comment has been minimized.

Copy link
Contributor Author

commented Jun 14, 2019

I'm going to add the API increase and some docs, but will be merged today to be ready for 11.1

@lkishalmi lkishalmi force-pushed the lkishalmi:NETBEANS-2654 branch from b355551 to abb9aa5 Jun 15, 2019

@lkishalmi

This comment has been minimized.

Copy link
Contributor Author

commented Jun 15, 2019

If travis checks out green then this shall go into master then to 11.1

@lkishalmi lkishalmi merged commit 525912c into apache:master Jun 15, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.