Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NETBEANS-2785] Move NIO2 File Watcher implementation into the front. #1349

Merged
merged 1 commit into from Jul 30, 2019

Conversation

@lkishalmi
Copy link
Contributor

lkishalmi commented Jul 2, 2019

Well, this change makes the existing NIO2 based file notifier implementation in fornt of the platform dependent ones (Positions: Windows: 100, MacOS: 300, Linux: 500)
However this is trivial change, I feel a bit late for 11.1, so I propose to merge it into master after the 11.1 is out.
If it works we can get rid of the platform specific implementations in NB 12.0

@lkishalmi lkishalmi added the NB11.2 label Jul 2, 2019
@lkishalmi lkishalmi requested review from geertjanw and JaroslavTulach Jul 2, 2019
@neilcsmith-net

This comment has been minimized.

Copy link
Member

neilcsmith-net commented Jul 3, 2019

@lkishalmi has anyone tested this on macOS? AFAIK macOS still doesn't have a real implementation of NIO2 watchers. I ship my own stuff without the native handlers and not noticed a problem, but there tend to be a lot less files in play at any one time there.

@lkishalmi

This comment has been minimized.

Copy link
Contributor Author

lkishalmi commented Jul 3, 2019

Well, indeed MacOS still uses the Poller implementation: https://hg.openjdk.java.net/jdk/jdk/file/19d0b382f086/src/java.base/macosx/classes/sun/nio/fs/BsdFileSystem.java
Thanks for pointing this out. I'm going to realign the positions according to that.

@JaroslavTulach JaroslavTulach requested a review from tzezula Jul 8, 2019
… platform dependent ones, makin it default.
@lkishalmi lkishalmi force-pushed the lkishalmi:NETBEANS-2785 branch from ee2f88e to c1fdcbf Jul 16, 2019
@lkishalmi

This comment has been minimized.

Copy link
Contributor Author

lkishalmi commented Jul 16, 2019

Changed the order to the following:

  • 100: MacOSX
  • 200: NIO2
  • 400: Windows
  • 500: Linux
@lkishalmi

This comment has been minimized.

Copy link
Contributor Author

lkishalmi commented Jul 23, 2019

@tzezula Any opinion on this? I'd like to introduce this one early in 11.2 so if it would cause problems we can detect/revert the change before the release process would really spin up for 11.2.

@lkishalmi

This comment has been minimized.

Copy link
Contributor Author

lkishalmi commented Jul 30, 2019

@geertjanw @JaroslavTulach shall we move this further. It is pretty easy to revert in case we need that. I'd like to see this in the Thursday's netbeans-dev snap drop.

Copy link
Contributor

JaroslavTulach left a comment

Let's try it.

@lkishalmi lkishalmi merged commit 4eb32c4 into apache:master Jul 30, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@junichi11 junichi11 added this to the 11.2 milestone Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.