New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NETBEANS-2917]: Support for yield in Switch-Expression for JDK-13 #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inside Switch Expression
arusinha-zz
changed the title
Netbeans 2917: Support for yield in Switch-Expression for JDK-13
[NETBEANS-2917]: Support for yield in Switch-Expression for JDK-13
Aug 6, 2019
rtaneja1
reviewed
Aug 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, Looks fine to me.
...on/test/unit/src/org/netbeans/modules/java/completion/JavaCompletionTask113FeaturesTest.java
Outdated
Show resolved
Hide resolved
java/java.source.base/src/org/netbeans/modules/java/source/pretty/VeryPretty.java
Outdated
Show resolved
Hide resolved
java/java.source.base/src/org/netbeans/modules/java/source/TreeShims.java
Outdated
Show resolved
Hide resolved
java/java.source.base/src/org/netbeans/modules/java/source/TreeShims.java
Outdated
Show resolved
Hide resolved
Had addressed all review comments in last commit |
rtaneja1
approved these changes
Aug 20, 2019
junichi11
added
the
Java
[ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form)
label
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Java
[ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for Yield with value for Switch Expression in JDK-13.
Broadly below issues will be addresses as part of yield support
This PR aims to cater Yield support needed in JDK 13 as per the below JEP
https://openjdk.java.net/jeps/354
Please refer below issue link for further details.
https://issues.apache.org/jira/browse/NETBEANS-2917