Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NETBEANS-2917]: Support for yield in Switch-Expression for JDK-13 #1409

Merged
merged 11 commits into from Aug 27, 2019

Conversation

arusinha-zz
Copy link

@arusinha-zz arusinha-zz commented Aug 6, 2019

Support for Yield with value for Switch Expression in JDK-13.

Broadly below issues will be addresses as part of yield support

  1. Syntax Highlighting of Yield keyword
  2. Formatting of Yield Tree
  3. Autocomplete of Yield Keyword.

This PR aims to cater Yield support needed in JDK 13 as per the below JEP
https://openjdk.java.net/jeps/354

Please refer below issue link for further details.
https://issues.apache.org/jira/browse/NETBEANS-2917

@arusinha-zz arusinha-zz changed the title Netbeans 2917: Support for yield in Switch-Expression for JDK-13 [NETBEANS-2917]: Support for yield in Switch-Expression for JDK-13 Aug 6, 2019
Copy link
Contributor

@rtaneja1 rtaneja1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, Looks fine to me.

@arusinha-zz
Copy link
Author

Had addressed all review comments in last commit

@arusinha-zz arusinha-zz merged commit 3ddcdc4 into apache:master Aug 27, 2019
@junichi11 junichi11 added this to the 11.2 milestone Aug 28, 2019
@junichi11 junichi11 added the Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) label Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants