Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NETBEANS-2661] Trying to avoid excessive computations by using Binar… #1430

Merged
merged 1 commit into from Sep 1, 2019

Conversation

@jlahoda
Copy link
Contributor

jlahoda commented Aug 16, 2019

…yForSource query on the current source root, rather than iterating through all binary roots and using SourceForBinaryQuery for them.

…yForSource query on the current source root, rather than iterating through all binary roots and using SourceForBinaryQuery for them.
@lkishalmi

This comment has been minimized.

Copy link
Contributor

lkishalmi commented Aug 23, 2019

On the first sight it looks sane. What is the "work-in-progress" label for? Are we expecting additional tests?

@jlahoda jlahoda requested review from geertjanw and lkishalmi Aug 28, 2019
@jlahoda

This comment has been minimized.

Copy link
Contributor Author

jlahoda commented Aug 28, 2019

I didn't have any particular/specific issues in mind, just wasn't sure if this is safe. But I guess the only way to really find out is to try it in the real world (the SourceForBinary and BinaryForSource queries should agree on the source<->binary mapping, and if they don't, we probably don't have a better way to find out than simply try - I briefly discussed this today with Tomas Zezula).

@lkishalmi lkishalmi merged commit 9679421 into apache:master Sep 1, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lkishalmi

This comment has been minimized.

Copy link
Contributor

lkishalmi commented Sep 1, 2019

Just tested it. The performance boost is awesome. It can be felt even for relative small set of projects. I have not find any problems with it so far.

@junichi11 junichi11 added this to the 11.2 milestone Sep 2, 2019
@geertjanw

This comment has been minimized.

Copy link
Member

geertjanw commented Sep 3, 2019

Just tested it. The performance boost is awesome. It can be felt even for relative small set of projects. I have not find any problems with it so far.

That's a great review of this PR. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.