Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NETBEANS-2941] Allow the IDE to see the compiler options in Gradle Projects #1494

Merged
merged 1 commit into from Sep 16, 2019

Conversation

@lkishalmi
Copy link
Contributor

lkishalmi commented Sep 11, 2019

As far as I could test this one works. I'd add more tests later on Gradle Projects after #1483 gets merged.

Copy link
Member

neilcsmith-net left a comment

Fine in principle. I'd rather merge ASAP if for 11.2. What's the comment about more tests? Before or after merging this?

@lkishalmi lkishalmi added the NB11.2 label Sep 16, 2019
@lkishalmi

This comment has been minimized.

Copy link
Contributor Author

lkishalmi commented Sep 16, 2019

Tests are meant to be after merging for this. I'm sorry responding a bit late, living in PDT and just seen the approval for this PR. It would be really nice to have it in 11.2 as it enables Gradle users to use JDK preview features with Gradle.

@neilcsmith-net

This comment has been minimized.

Copy link
Member

neilcsmith-net commented Sep 16, 2019

No problem! Merge it when you're ready.

@lkishalmi lkishalmi force-pushed the lkishalmi:NETBEANS-2941 branch from c89d43e to 5e21bc0 Sep 16, 2019
@neilcsmith-net neilcsmith-net added this to the 11.2 milestone Sep 16, 2019
@lkishalmi lkishalmi force-pushed the lkishalmi:NETBEANS-2941 branch from 5e21bc0 to 3ada8d6 Sep 16, 2019
@lkishalmi lkishalmi merged commit de5920c into apache:master Sep 16, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.