Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NETBEANS-84] - Add Support for JSF 2.3 #1576

Closed
wants to merge 14 commits into from

Conversation

@juneau001
Copy link
Contributor

juneau001 commented Oct 18, 2019

  • Added JSF 2.3 tag library
  • Modified core to include new types
  • Adjusted code to include references to JSF 2.3
  • Added new external library reference and license for org.glassfish:javax.faces:2.3.9:jar
@geertjanw geertjanw added the nb11.3 label Oct 18, 2019
@junichi11 junichi11 added this to the 11.3 milestone Oct 18, 2019
@junichi11

This comment has been minimized.

Copy link
Member

junichi11 commented Oct 18, 2019

Let's use the milestone instead of the version labels :) because version labels continue to increase and they are never used after specific versions are released.

@juneau001

This comment has been minimized.

Copy link
Contributor Author

juneau001 commented Oct 18, 2019

Prior to my commit, I synced my fork. However, I did not cherry pick the commit for JSF 2.3, so it included a number of my previous commits as well. Should I close this PR and clean up by cherry picking only the latest commit? Thanks

@junichi11

This comment has been minimized.

Copy link
Member

junichi11 commented Oct 19, 2019

@juneau001 We can squash and merge your commits via GitHub "Squash and merge" button. i.e. Your commits will be just one commit if the person who merges this does that. So, if it is OK with you, you can leave it as it is. Of course, if you would like to squash them properly yourself in your local environment, you can do that then can push (force) it the same branch(NETBEANS-84). So, I don't think you need to close this :)

@matthiasblaesing

This comment has been minimized.

Copy link
Contributor

matthiasblaesing commented Oct 19, 2019

@juneau001 I have better experience with using rebasing patches, instead of merging the base branch into the feature branch as done here. For me the rebasing leads to a history, that can be much easier be refactored/cleaned up.

@juneau001

This comment has been minimized.

Copy link
Contributor Author

juneau001 commented Nov 14, 2019

I am closing this pull request because I have made additional changes. I will also rebase my fork again before opening new pull request.

@juneau001 juneau001 closed this Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.