[NETBEANS-3644] Adjusted Welcome Screent to FlatLAF #1826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkishalmi
force-pushed
the
NETBEANS-3644-2
branch
from
72d9e87
to
635aad3
Compare
|
|
|
Also changed the output colors matching goes better with the FlatLaf Dark editor theme: |
|
I'm not sure, but I think I see negative fallout from this. I noticed today, that the start screen of the master build looked strange:
The screenshot was taken on Ubuntu 19.10 with Xfce4 as desktop environment. This was observed with the Ubuntu provided Open JDK 11.0.5 and Oracle JDK 1.8.0_201. The LAF is Metall (automatically chosen). Could you please have a look at this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There would be still some work to do, like the colors of the hyperlinks and the logo for the light theme shall be adjusted, that is for another PR. I think this one is still an improvement.